Skip to content

[Driver] Pass optimization options to sycl-post-link #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

DenisBakhvalov
Copy link
Contributor

@DenisBakhvalov DenisBakhvalov commented Feb 11, 2021

This is one of the patches for moving ESIMD passes from clang FE (BackendUtils.cpp) to sycl-post-link.
This patch is a continuation for #3195 and it passes the optimization level to the sycl-post-link.

@DenisBakhvalov DenisBakhvalov marked this pull request as ready for review February 15, 2021 20:43
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@DenisBakhvalov
Copy link
Contributor Author

@AGindinson, please review.

Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in brief review - my approval is secondary for merging this.

@DenisBakhvalov
Copy link
Contributor Author

@bader, please merge.

@bader
Copy link
Contributor

bader commented Feb 18, 2021

@DenisBakhvalov, is there any documentation about how sycl-post-link is used for ESIMD feature implementation? I looked through existing documentation, but it doesn't mention sycl-post-link.

@bader bader merged commit 47b85e5 into intel:sycl Feb 18, 2021
@DenisBakhvalov
Copy link
Contributor Author

@DenisBakhvalov, is there any documentation about how sycl-post-link is used for ESIMD feature implementation? I looked through existing documentation, but it doesn't mention sycl-post-link.

The doc doesn't mention this yet, but I have a TODO for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants