[SYCL][NFC] Fix Windows warnings, sync usage of class/struct with new… #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
previously approved these changes
Jul 17, 2019
| @@ -40,7 +40,8 @@ getOrWaitEvents(std::vector<cl::sycl::event> DepEvents, | |||
|
|
|||
| void waitEvents(std::vector<cl::sycl::event> DepEvents); | |||
|
|
|||
| struct Builder { | |||
| class Builder { | |||
There was a problem hiding this comment.
Builder struct is not part of the SYCL specification.
Did you decide to avoid using struct for all types in our project - even for internal?
There was a problem hiding this comment.
That is already 3rd time when I fix something for Builder. Have no idea why, but Builder tends to be treated as class by other developers.
… SYCL SPEC Signed-off-by: Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_windows_warnings
branch
from
f232b86 to
e26cc42
Compare
|
It looks like I forgot to run check-sycl before uploading it yesterday. Testing showed that I forgot 'public:' keyword at the beginning of 'class item' definition. |
bader
approved these changes
Jul 17, 2019
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Sergey Kanaev <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…uite#355) Signed-off-by: Sergey Kanaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… SYCL SPEC
Signed-off-by: Klochkov [email protected]