[SYCL] Disable checks on host device in kernel_bundle_api #3341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirlaz
previously approved these changes
Mar 11, 2021
bader
requested changes
Mar 11, 2021
There was a problem hiding this comment.
According to the contribution guide this test should be moved to llvm-test-suite or it can be temporarily located in sycl/test/on-device.
https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md#tests-development
vladimirlaz
suggested changes
Mar 11, 2021
| @@ -13,6 +13,11 @@ class Kernel2Name; | |||
|
|
|||
| int main() { | |||
| sycl::queue Q; | |||
|
|
|||
There was a problem hiding this comment.
can we add RUN lines per target device?
There was a problem hiding this comment.
Yes, we can. But it doesn't make a lot of sense to run the test on many devices many devices. We could specify only one, but it seems it is unknown/undefined which devices are available on CI machines.
bader
approved these changes
Mar 11, 2021
vladimirlaz
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.