Skip to content

[SYCL] Disable checks on host device in kernel_bundle_api #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2021
Merged

[SYCL] Disable checks on host device in kernel_bundle_api #3341

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a28215d
[SYCL] Disable checks on host device in kernel_bundle_api
romanovvlad Mar 11, 2021
31c6f35
move test
romanovvlad Mar 11, 2021
300516c
fix clang-format
romanovvlad Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...tests/kernel_bundle/kernel_bundle_api.cpp → ...tests/kernel_bundle/kernel_bundle_api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ class Kernel2Name;

int main() {
sycl::queue Q;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add RUN lines per target device?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can. But it doesn't make a lot of sense to run the test on many devices many devices. We could specify only one, but it seems it is unknown/undefined which devices are available on CI machines.

// No support for host device so far.
if (Q.is_host())
return 0;

const sycl::context Ctx = Q.get_context();
const sycl::device Dev = Q.get_device();

Expand Down