[SPIR-V] Remove FuncParamKindINTEL and FuncParamDescINTEL

[MrSidims]

These decorations doesn't present in https://github.com/KhronosGroup/SPIRV-LLVM-Translator

Signed-off-by: Dmitry Sidorov [email protected]

[NikitaRudenkoIntel]

The patch with DecorationFuncParamKindINTEL and DecorationFuncParamDescINTEL is not needed anymore and could be reverted.

[NikitaRudenkoIntel]

Before merging, make sure that this repo uses GenXSPIRVWriterAdaptor from vc-intrinsics with RewriteTypes parameter set to true.

[MrSidims]

Before merging, make sure that this repo uses GenXSPIRVWriterAdaptor from vc-intrinsics with RewriteTypes parameter set to true.

Looks like it doesn't.
llvm$ grep -rn GenXSPIRVWriterAdaptor --color
llvm/tools/sycl-post-link/sycl-post-link.cpp:23:#include "llvm/GenXIntrinsics/GenXSPIRVWriterAdaptor.h"
llvm/tools/sycl-post-link/sycl-post-link.cpp:517: MPM.add(createGenXSPIRVWriterAdaptorPass());
llvm$ grep -rn RewriteTypes
llvm$

[NikitaRudenkoIntel]

Well, you probably should create a PR with enabling this option. See also:
https://github.com/intel/vc-intrinsics/blob/master/GenXIntrinsics/include/llvm/GenXIntrinsics/GenXSPIRVWriterAdaptor.h

[bader]

@MrSidims, @AlexeySotkin, @AlexeySachkov, ping.

[NikitaRudenkoIntel]

BTW I created a corresponding issue and PR:
#3607
It is awaiting driver update in Jenkins, which fixes a problem causing failure after enabling RewriteTypes

[MrSidims]

I guess this PR is no longer needed

[AlexeySachkov]

@MrSidims, why so? Have we removed those decorations already in some other PR?

[MrSidims]

@MrSidims, why so? Have we removed those decorations already in some other PR?

I though so, because otherwise we couldn't move to external SPIR-V Headers. But I see now, that FuncParamKindINTEL and FuncParamDescINTEL were just moved into spirv_internal.hpp .