[SYCL][ESIMD] Deprecate block_load/store, add simd::copy_from/to. #3572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rolandschulz, FYI |
|
End-to-end tests: intel/llvm-test-suite#236 |
kbobrovs
force-pushed
the
rename_block_load
branch
3 times, most recently
from
9a86a2c to
429363c
Compare
romanovvlad
reviewed
Apr 19, 2021
romanovvlad
reviewed
Apr 20, 2021
This patch: 1) Fixes the following TODO in esimd_memory.hpp: // TODO @rolandschulz // Should follow existing std::simd naming for similar APIs - "copy_from" and // "copy_to" to avoid confusion. 2) Adds type checks for the sycl accessor arguments in the added APIs. Signed-off-by: kbobrovs <[email protected]>
Signed-off-by: kbobrovs <[email protected]>
Signed-off-by: kbobrovs <[email protected]>
Signed-off-by: kbobrovs <[email protected]>
Signed-off-by: kbobrovs <[email protected]>
kbobrovs
force-pushed
the
rename_block_load
branch
from
1d9ab75 to
6f6752c
Compare
|
had to rebase and force-push to resolve conflicts. @romanovvlad, @DenisBakhvalov - sorry for delay. Please review. |
kbobrovs
commented
May 4, 2021
DenisBakhvalov
previously approved these changes
May 4, 2021
Signed-off-by: kbobrovs <[email protected]>
Signed-off-by: kbobrovs <[email protected]>
|
@DenisBakhvalov - I saw you reviewed 1 hour ago, somehow I did not see any comments. Were there any? If none - please approve. @romanovvlad - please approve if there a no other comments. |
DenisBakhvalov
approved these changes
May 4, 2021
romanovvlad
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Fixes the following TODO in esimd_memory.hpp:
// TODO @rolandschulz
// Should follow existing std::simd naming for similar APIs - "copy_from" and
// "copy_to" to avoid confusion.
Adds type checks for the sycl accessor arguments in the added APIs.
Signed-off-by: kbobrovs [email protected]