Skip to content

Undo #2143 to check if problem in issue #645 still actual #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

KornevNikita
Copy link
Contributor

No description provided.

@KornevNikita KornevNikita requested a review from bader as a code owner June 30, 2021 09:14
@KornevNikita
Copy link
Contributor Author

/summary:run

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, "undo" changes with git revert 2fb2468474af921e8f79a38808096201b391ab99 to revert all the changes.

@KornevNikita
Copy link
Contributor Author

/summary:run

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, resolve merge conflicts.

@KornevNikita
Copy link
Contributor Author

Something wrong with reverting, I'll try again

@KornevNikita KornevNikita deleted the temp branch June 30, 2021 09:32
@bader
Copy link
Contributor

bader commented Jun 30, 2021

/summary:run

Please, do not run summary job. It's not necessary - there should be no difference with previous results because new version is supposed to change only code comments and lit test, which are not validated by this job.

@bader
Copy link
Contributor

bader commented Jun 30, 2021

Something wrong with reverting, I'll try again

The easiest way to fix it, revert your patch first to recover original sycl branch state and apply the command I suggested after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants