[SPIR][InstCombine] Work around SPIR-V translator limitation #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is temporary work-around for a problem reported here: KhronosGroup/SPIRV-LLVM-Translator#645 InstCombine canonical form for this pattern ``` // Example (little endian): // trunc (extractelement <4 x i64> %X, 0) to i32 // ---> // extractelement <8 x i32> (bitcast <4 x i64> %X to <8 x i32>), i32 0 ``` can't be lowered by SPIR-V translator to "standard" format.
romanovvlad
requested changes
Jul 20, 2020
There was a problem hiding this comment.
Please, add a test.
Also I would like @againull and @dendibakh to take a look as well.
|
LGTM |
|
LGTM |
romanovvlad
previously approved these changes
Jul 21, 2020
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Jun 30, 2021
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Jun 30, 2021
…ntel#2143)" This reverts commit 2fb2468.
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Jun 30, 2021
…ntel#2143)" This reverts commit 2fb2468.
jsji
pushed a commit
that referenced
this pull request
Sep 7, 2023
visit method of the sort relies on getNonLiteralOperands method of the SPIRVType which is being inserted in the module. Without it dependent types can be inserted in the module in incorrect order. For example: TypeCooperativeMatrixKHR %ID% TypeStruct ... %ID% is the correct order, but without the patch in some cases the translator could generate the opposite order. Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@436c497
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Return more accurate errors from CL's ProgramCreateWithIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is temporary work-around for a problem reported here:
KhronosGroup/SPIRV-LLVM-Translator#645
InstCombine canonical form for this pattern
can't be lowered by SPIR-V translator to "standard" format.