Revert "[SPIR][InstCombine] Work around SPIR-V translator limitation … #4028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntel#2143)" This reverts commit 2fb2468.
bader
requested changes
Jun 30, 2021
There was a problem hiding this comment.
The #4026 pre-commit results show the test case requiring this patch:
http://ci.llvm.intel.com:8010/#/builders/2/builds/15098/steps/16/logs/FAIL__SYCL__lower-external-funcs_cpp
@AlexeySotkin, FYI.
|
@KornevNikita http://ci.llvm.intel.com:8010/#/builders/2/builds/15098/steps/16/logs/FAIL__SYCL__lower-external-funcs_cpp this is example of non-standard type which we should handle(convert to standard type if possible) in the translator. |
|
I suggest we close this PR. |
|
Closing PR as it was only needed to check the relevance of the problem with bitcasting to non-standard SPIR-V types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#2143)"
This reverts commit 2fb2468.