-
Notifications
You must be signed in to change notification settings - Fork 789
[SYCL] Changed USM copy src and dst parameter order #4037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As noted in #3897 (comment), a spec bug was identified. The USM `copy` member functions take the `src` and `dst` parameters in the wrong order. The order should be `(src, dst)`, which matches the standard C++ `copy` function and matches the existing SYCL `copy` functions that take accessor parameters.
There are currently no tests in https://github.com/intel/llvm-test-suite for the newly-added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-reviewers-runtime, ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this change break API compatibility?
That is, when compiling existing application source, the dst and src are in different order than expected.
These functions have only been added in #3897, so we should be fine here (unless we care about maintaining API compatibility not just between releases, but also between commits). |
Sounds OK to me, then. |
As noted in #3897 (comment),
a spec bug was identified. The USM
copy
member functions take thesrc
and
dst
parameters in the wrong order. The order should be(src, dst)
,which matches the standard C++
copy
function and matches the existingSYCL
copy
functions that take accessor parameters.Tests: intel/llvm-test-suite#342