Skip to content

[SYCL] Changed USM copy src and dst parameter order #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2021
Merged

[SYCL] Changed USM copy src and dst parameter order #4037

merged 1 commit into from
Jul 5, 2021

Conversation

dnmokhov
Copy link
Contributor

@dnmokhov dnmokhov commented Jul 1, 2021

As noted in #3897 (comment),
a spec bug was identified. The USM copy member functions take the src
and dst parameters in the wrong order. The order should be (src, dst),
which matches the standard C++ copy function and matches the existing
SYCL copy functions that take accessor parameters.

Tests: intel/llvm-test-suite#342

As noted in #3897 (comment),
a spec bug was identified. The USM `copy` member functions take the `src`
and `dst` parameters in the wrong order. The order should be `(src, dst)`,
which matches the standard C++ `copy` function and matches the existing
SYCL `copy` functions that take accessor parameters.
@dnmokhov dnmokhov requested review from cperkinsintel and gmlueck July 1, 2021 23:17
@dnmokhov dnmokhov marked this pull request as ready for review July 1, 2021 23:17
@dnmokhov dnmokhov requested a review from a team as a code owner July 1, 2021 23:17
@dnmokhov
Copy link
Contributor Author

dnmokhov commented Jul 1, 2021

There are currently no tests in https://github.com/intel/llvm-test-suite for the newly-added copy. I am working on them and will update them to use the new version before posting a pull request.

Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

FYI: @mkinsner @jbrodman
This changes the order of the USM copy parameters as we discussed.

Copy link

@mkinsner mkinsner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader
Copy link
Contributor

bader commented Jul 5, 2021

@intel/llvm-reviewers-runtime, ping.

s-kanaev
s-kanaev previously approved these changes Jul 5, 2021
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change break API compatibility?
That is, when compiling existing application source, the dst and src are in different order than expected.

@s-kanaev s-kanaev dismissed their stale review July 5, 2021 14:41

Wrong review.

@sergey-semenov
Copy link
Contributor

Will this change break API compatibility?
That is, when compiling existing application source, the dst and src are in different order than expected.

These functions have only been added in #3897, so we should be fine here (unless we care about maintaining API compatibility not just between releases, but also between commits).

@s-kanaev
Copy link
Contributor

s-kanaev commented Jul 5, 2021

These functions have only been added in #3897, so we should be fine here (unless we care about maintaining API compatibility not just between releases, but also between commits).

Sounds OK to me, then.

@bader bader merged commit 4236bbb into intel:sycl Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants