[SYCL][FPGA] Refactor of [[intel::bankwidth()]] and [[intel::numbanks()]] attributes #4513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…()]] attributes Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
AaronBallman
reviewed
Sep 8, 2021
Signed-off-by: Soumi Manna <[email protected]>
AaronBallman
reviewed
Sep 8, 2021
DoyleLi
pushed a commit
to DoyleLi/intel_llvm
that referenced
this pull request
Sep 13, 2021
…()]] attributes (intel#4513) This patch 1. refactors two FPGA memory attributes to align with upstream: [[intel::bankwidth()]] [[intel::numbanks()]] 2. refactors the way we handle duplicate attributes and mutually exclusive attributes logic when present on a given declaration. 3. handles redeclarations or template instantiations properly. 4. adds test 5. removes generic function "AddOneConstantPowerTwoValueAttr" Signed-off-by: Soumi Manna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
refactors two FPGA memory attributes to align with upstream:
[[intel::bankwidth()]]
[[intel::numbanks()]]
refactors the way we handle duplicate attributes and
mutually exclusive attributes logic when present on a given declaration.
handles redeclarations or template instantiations properly.
adds test
removes generic function "AddOneConstantPowerTwoValueAttr"
Signed-off-by: Soumi Manna [email protected]