[SYCL] Avoid rebuilding sycl library every time #4710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL/XPTI headers were copyied every time the build has triggered. That invalidates all compilation that depend on them. As result, SYCL library and some other targets were rebuilt on every build. This change makes CMake copy header only they have changed. Also version.hpp file is generated directly in build directory to avoid copy step. Remove redundant include of header as source file.
vladimirlaz
requested review from
alexbatashev,
andykaylor,
tovinkere and
a team
as code owners
alexbatashev
approved these changes
Oct 6, 2021
All kudos to @tcreech-intel who suggested the patch |
vladimirlaz
added a commit
that referenced
this pull request
Oct 7, 2021
This is follow up for #4710 When a sub-directory of the DEPENDS directories is modified the change is not detected by CMake. The change adds a full list of files in the sub-directory to DEPENDS to detect the change. file(GLOBE_RECURSE) is used with CONFIGURE_DEPENDS option to rerun configure step if a new entry is added to the directory structure. Restore version.hpp in source directory as it is used to build SYCL library. Removing a header file is the only case when change is not propagated to the build and install directory. This problem existed before the change and TODO was left to fix it in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL/XPTI headers were copyied every time the build has triggered. That
invalidates all compilation that depend on them. As result, SYCL library
and some other targets were rebuilt on every build. This change makes
CMake copy header only they have changed.
Also version.hpp file is generated directly in build directory to avoid
copy step.
Remove redundant include of header as source file.