[SYCL] Detect changes in sycl headers #4723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When subdirectory of the DEPENDS directories are modified the change is not detected by CMake. The change set full list of files in subdirectory to DEPENDS to detect the change. file(GLOBE_RECURSE) is used with CONFIGURE_DEPENDS option to rerun configure if new entry is added to directory structure. Restore version.hpp in source directory as it is used to build SYCL library. Removing header file is the only case when change is not propagated to build and install directory. This problem existed before the change and TODO was left to fix it in future.
vladimirlaz
requested review from
alexbatashev,
andykaylor,
tovinkere and
a team
as code owners
alexbatashev
previously approved these changes
Oct 7, 2021
The use of build directory as source for install causing duplication of level_zero headers.
alexbatashev
approved these changes
Oct 7, 2021
|
The failure is unrelated to the change and is under investigation. |
|
Because |
The latest release https://github.com/intel/llvm/releases/tag/sycl-nightly%2F20211008 contains version.hpp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up for #4710
When a sub-directory of the DEPENDS directories is modified the change is not
detected by CMake. The change adds a full list of files in the sub-directory to
DEPENDS to detect the change. file(GLOBE_RECURSE) is used with
CONFIGURE_DEPENDS option to rerun configure step if a new entry is added to
the directory structure.
Restore version.hpp in source directory as it is used to build SYCL
library.
Removing a header file is the only case when change is not propagated to
the build and install directory. This problem existed before the change and
TODO was left to fix it in the future.