Skip to content

[SYCL] Revert USM caching to pre-2021.3 state and disable Shared USM … #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 31, 2021

Conversation

rdeodhar
Copy link
Contributor

This change a) enhances the env var controls for USM caching, b) sets caching parameters to match the previous implementation and c) disables Shared memory chunking to fix a data race issue.

Signed-off-by: Rajiv Deodhar [email protected]

@rdeodhar
Copy link
Contributor Author

The tests usm_pooling.cpp and usm_leak_check.cpp are expected to fail.
PR intel/llvm-test-suite#529 disable those tests.

@rdeodhar rdeodhar marked this pull request as ready for review October 22, 2021 00:25
@rdeodhar rdeodhar requested a review from againull as a code owner October 22, 2021 00:25
@againull
Copy link
Contributor

/summary:run

againull
againull previously approved these changes Oct 23, 2021
Copy link
Contributor

@againull againull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pooling changes look good to me.

@againull
Copy link
Contributor

@pvchupin @bader Could you please approve doc changes.

@againull againull self-requested a review October 25, 2021 19:23
againull added a commit to againull/llvm-test-suite that referenced this pull request Oct 27, 2021
…ests

Memory pooling is being disabled by default:
intel/llvm#4799

This makes necessary to enable indirect access tracking feature for
multi-threaded assertion tests. Memory pooling was resulting in deferred
memory release that's why this issue was not reproducing before.
againull added a commit to againull/llvm-test-suite that referenced this pull request Oct 27, 2021
…ests

Memory pooling is being disabled by default:
intel/llvm#4799

This makes necessary to enable indirect access tracking feature for
multi-threaded assertion tests. Memory pooling was resulting in deferred
memory release that's why this issue was not reproducing before.
vladimirlaz pushed a commit to intel/llvm-test-suite that referenced this pull request Oct 27, 2021
…ests (#538)

Memory pooling is being disabled by default:
intel/llvm#4799

This makes necessary to enable indirect access tracking feature for
multi-threaded assertion tests. Memory pooling was resulting in deferred
memory release that's why this issue was not reproducing before.
@againull againull merged commit a0342b3 into intel:sycl Oct 31, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…ests (intel/llvm-test-suite#538)

Memory pooling is being disabled by default:
intel#4799

This makes necessary to enable indirect access tracking feature for
multi-threaded assertion tests. Memory pooling was resulting in deferred
memory release that's why this issue was not reproducing before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants