-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Revert USM caching to pre-2021.3 state and disable Shared USM … #4799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunking. Signed-off-by: Rajiv Deodhar <[email protected]>
The tests usm_pooling.cpp and usm_leak_check.cpp are expected to fail. |
/summary:run |
againull
previously approved these changes
Oct 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pooling changes look good to me.
bader
reviewed
Oct 25, 2021
Co-authored-by: Alexey Bader <[email protected]>
pvchupin
approved these changes
Oct 25, 2021
againull
approved these changes
Oct 25, 2021
againull
added a commit
to againull/llvm-test-suite
that referenced
this pull request
Oct 27, 2021
…ests Memory pooling is being disabled by default: intel/llvm#4799 This makes necessary to enable indirect access tracking feature for multi-threaded assertion tests. Memory pooling was resulting in deferred memory release that's why this issue was not reproducing before.
againull
added a commit
to againull/llvm-test-suite
that referenced
this pull request
Oct 27, 2021
…ests Memory pooling is being disabled by default: intel/llvm#4799 This makes necessary to enable indirect access tracking feature for multi-threaded assertion tests. Memory pooling was resulting in deferred memory release that's why this issue was not reproducing before.
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Oct 27, 2021
…ests (#538) Memory pooling is being disabled by default: intel/llvm#4799 This makes necessary to enable indirect access tracking feature for multi-threaded assertion tests. Memory pooling was resulting in deferred memory release that's why this issue was not reproducing before.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ests (intel/llvm-test-suite#538) Memory pooling is being disabled by default: intel#4799 This makes necessary to enable indirect access tracking feature for multi-threaded assertion tests. Memory pooling was resulting in deferred memory release that's why this issue was not reproducing before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change a) enhances the env var controls for USM caching, b) sets caching parameters to match the previous implementation and c) disables Shared memory chunking to fix a data race issue.
Signed-off-by: Rajiv Deodhar [email protected]