[SYCL] Diagnose non-forward declarable kernel name types #4945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional error emission in host mode
because only on host with help of integration header possible to
differentiate case like this:
```
int main() {
parallel_for<class KernelName>(..);
}
```
which uses technically non-forward declarable kernel name type but
still allowed by SYCL spec, from case like this:
```
int main() {
class KernelName;
parallel_for<class KernelName>(..);
}
```
which should be diagnosed, since the errors are emitted in runtime.
Everything works when `KernelName` typename is used directly in
`parallel_for`, because in this case when the type `KernelName` is
forward declared by integration header, host uses `::KernelName`
typename to access kernel info.
However when `KernelName` is forward declared in non-global/namespace
scope it actually produces a separate delclaration `main::KernelName`
which is not visible for runtime code that submits kernels.
Fznamznon
requested review from
elizabethandrews,
premanandrao,
smanna12 and
a team
as code owners
smanna12
reviewed
Nov 15, 2021
smanna12
previously approved these changes
Nov 15, 2021
dm-vodopyanov
approved these changes
Nov 17, 2021
smanna12
approved these changes
Nov 17, 2021
|
It has been approved for 5 days. Is there anything else required to merge this patch? |
Fznamznon
added a commit
to Fznamznon/llvm
that referenced
this pull request
Nov 29, 2021
intel#4945 introduced a new diagnostic that works correcly only if integration header is included. However it is possible that `-fsycl-is-host` flag can be used without integration header, so the diagnostic should be issued only if integration header is incuded. This patch adds new cc1 option that helps to understand that.
erichkeane
reviewed
Nov 29, 2021
| // } | ||
| // The device compiler forward declares both KernelName1 and | ||
| // KernelName2 in the integration header as ::KernelName1 and | ||
| // ::KernelName2. The problem with the former case is the additional |
There was a problem hiding this comment.
So note that this (the ::KernelName1 and ::KernelName2) isn't exactly true, if the function is in a namespace, we try our best to get the name in as close of a namespace as possible (though your example uses 'main', so thats not exactly a concern).
bader
pushed a commit
that referenced
this pull request
Dec 2, 2021
…er (#5044) #4945 introduced a new diagnostic that works correctly only if integration header is included. However it is possible that `-fsycl-is-host` flag can be used without integration header, so the diagnostic should be issued only if integration header is included. This patch adds new cc1 option that helps to understand that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional error emission in host mode
because only on host with help of integration header possible to
differentiate case like this:
which uses technically non-forward declarable kernel name type but
still allowed by SYCL spec, from case like this:
which should be diagnosed, since the errors are emitted in runtime.
Everything works when
KernelNametypename is used directly inparallel_for, because in this case when the typeKernelNameisforward declared by integration header, host uses
::KernelNametypename to access kernel info.
However when
KernelNameis forward declared in non-global/namespacescope it actually produces a separate delclaration
main::KernelNamewhich is not visible for runtime code that submits kernels.