[SYCL] Conditionally enable diagnosing that requires integration header #5044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel#4945 introduced a new diagnostic that works correcly only if integration header is included. However it is possible that `-fsycl-is-host` flag can be used without integration header, so the diagnostic should be issued only if integration header is incuded. This patch adds new cc1 option that helps to understand that.
Fznamznon
requested review from
AaronBallman,
erichkeane,
mdtoguchi and
elizabethandrews
elizabethandrews
previously approved these changes
Nov 29, 2021
erichkeane
reviewed
Nov 29, 2021
mdtoguchi
previously approved these changes
Nov 29, 2021
Fznamznon
changed the title
Fznamznon
dismissed stale reviews from mdtoguchi and elizabethandrews
via
20920a3
erichkeane
approved these changes
Nov 30, 2021
Fznamznon
requested review from
AGindinson,
hchilama,
premanandrao,
smanna12 and
a team
as code owners
mdtoguchi
approved these changes
Nov 30, 2021
smanna12
approved these changes
Nov 30, 2021
premanandrao
approved these changes
Nov 30, 2021
steffenlarsen
approved these changes
Nov 30, 2021
|
Can this one be merged? It appears to be quite important for the downstream. |
|
/summary:run |
The tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4945 introduced a new diagnostic that
works correcly only if integration header is included. However it is
possible that
-fsycl-is-hostflag can be used without integrationheader, so the diagnostic should be issued only if integration header is
incuded. This patch adds new cc1 option that helps to understand that.