-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Use teams to assign code ownership #5016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vladimirlaz, please, use a private fork to open a pull request. |
Co-authored-by: Alexey Bader <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPIR-V part looks good to me.
@vladimirlaz, ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of suggestions, which hopefully are okay.
@vladimirlaz, is there an infrastructure team we can assign as a code owner for .github script sources? |
@vladimirlaz, please, resolve merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fix pre-commit checks.
sycl/source/detail/posix_pi.cpp @smaslov-intel | ||
sycl/source/detail/windows_pi.cpp @smaslov-intel | ||
# Level Zero plugin | ||
sycl/sycl/plugins/level_zero @intel/dpcpp-l0-pi-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vladimirlaz, code review assignment is broken.
I think it's due to bugs in the .github/CODEOWNERS file.
sycl/sycl/plugins/level_zero -> sycl/plugins/level_zero?
# Driver | ||
clang/**/Driver @mdtoguchi @AGindinson @hchilama | ||
# Clang driver | ||
clang/**/Driver @intel/dpcpp-clang-driver-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make sure that all these teams exist and have write access to the repository.
I can't assign intel/dpcpp-clang-driver-reviewers as #5239 reviewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed for all teams both in intel/llvm and intel/llvm-test-suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Please, test automatic assignment. I think it's still broken due to the issue in my previous comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it worked on change of the sources in the PR (fixed 2 hours form now). No automatic assignemnt for existent PR.
No description provided.