Skip to content

[SYCL] Use teams to assign code ownership #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 27, 2021
Merged

Conversation

vladimirlaz
Copy link
Contributor

No description provided.

@vladimirlaz vladimirlaz requested a review from bader as a code owner November 23, 2021 09:36
@vladimirlaz vladimirlaz marked this pull request as draft November 23, 2021 09:36
@vladimirlaz vladimirlaz changed the title Use teams to assign code ownership [SYCL] Use teams to assign code ownership Nov 23, 2021
@bader
Copy link
Contributor

bader commented Nov 23, 2021

@vladimirlaz, please, use a private fork to open a pull request.

AlexeySotkin
AlexeySotkin previously approved these changes Nov 23, 2021
Copy link
Contributor

@AlexeySotkin AlexeySotkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPIR-V part looks good to me.

@bader
Copy link
Contributor

bader commented Dec 15, 2021

@vladimirlaz, ping.

@vladimirlaz vladimirlaz marked this pull request as ready for review December 17, 2021 09:35
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of suggestions, which hopefully are okay.

@bader
Copy link
Contributor

bader commented Dec 21, 2021

@vladimirlaz, is there an infrastructure team we can assign as a code owner for .github script sources?

@bader
Copy link
Contributor

bader commented Dec 27, 2021

@vladimirlaz, please, resolve merge conflicts.

@vladimirlaz vladimirlaz requested a review from bader December 27, 2021 15:18
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix pre-commit checks.

@alexbatashev
Copy link
Contributor

@bader bader merged commit 2cb9e90 into sycl Dec 27, 2021
@bader bader deleted the vladimirlaz-codownership branch December 27, 2021 18:43
sycl/source/detail/posix_pi.cpp @smaslov-intel
sycl/source/detail/windows_pi.cpp @smaslov-intel
# Level Zero plugin
sycl/sycl/plugins/level_zero @intel/dpcpp-l0-pi-reviewers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladimirlaz, code review assignment is broken.
I think it's due to bugs in the .github/CODEOWNERS file.

sycl/sycl/plugins/level_zero -> sycl/plugins/level_zero?

# Driver
clang/**/Driver @mdtoguchi @AGindinson @hchilama
# Clang driver
clang/**/Driver @intel/dpcpp-clang-driver-reviewers
Copy link
Contributor

@bader bader Dec 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure that all these teams exist and have write access to the repository.

I can't assign intel/dpcpp-clang-driver-reviewers as #5239 reviewer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed for all teams both in intel/llvm and intel/llvm-test-suite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Please, test automatic assignment. I think it's still broken due to the issue in my previous comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked on change of the sources in the PR (fixed 2 hours form now). No automatic assignemnt for existent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants