Skip to content

[SYCL] Use teams to assign code ownership #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 27, 2021
Merged

[SYCL] Use teams to assign code ownership #5016

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98a6997
Use teams to assign code ownership
vladimirlaz Nov 23, 2021
15e1b49
Apply suggestions from code review
vladimirlaz Nov 23, 2021
409d034
Apply reveiw comments
vladimirlaz Nov 23, 2021
7a0f661
Apply offline review comments
vladimirlaz Nov 30, 2021
947cca3
Apply review comments
vladimirlaz Dec 27, 2021
ad717b5
Merge remote-tracking branch 'origin/sycl' into vladimirlaz-codownership
vladimirlaz Dec 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 22 additions & 83 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,116 +1,55 @@
* @bader

# Front-end compiler
clang/ @premanandrao @elizabethandrews @smanna12
clang/ @intel/dpcpp-cfe-reviewers

# Driver
clang/**/Driver @mdtoguchi @AGindinson @hchilama
# Clang driver
clang/**/Driver @intel/dpcpp-clang-driver-reviewers
Copy link
Contributor

@bader bader Dec 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure that all these teams exist and have write access to the repository.

I can't assign intel/dpcpp-clang-driver-reviewers as #5239 reviewer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed for all teams both in intel/llvm and intel/llvm-test-suite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Please, test automatic assignment. I think it's still broken due to the issue in my previous comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked on change of the sources in the PR (fixed 2 hours form now). No automatic assignemnt for existent PR.


# LLVM-SPIRV translator
llvm-spirv/ @AlexeySotkin @AlexeySachkov
llvm-spirv/ @intel/dpcpp-spirv-reviewers

# OpenCL deps
opencl/ @pvchupin @vladimirlaz
opencl/ @intel/llvm-reviewers-runtime

# OpenCL "offline" compiler
opencl/opencl-aot/ @dm-vodopyanov @AlexeySachkov @romanovvlad
opencl/opencl-aot/ @intel/dpcpp-tools-reviewers

# Device library
libdevice/ @vzakhari @jinge90
libdevice/ @intel/llvm-reviewers-runtime

# DPC++ runtime library
sycl/ @intel/llvm-reviewers-runtime

# Documentation
sycl/ReleaseNotes.md @pvchupin @tfzhu
sycl/doc/ @pvchupin @bader
sycl/ReleaseNotes.md @intel/dpcpp-doc-reviewers
sycl/doc/ @intel/dpcpp-doc-reviewers
sycl/doc/design/ @intel/dpcpp-specification-reviewers
sycl/doc/extensions/ @intel/dpcpp-specification-reviewers
sycl/doc/extensions/SPIRV/ @AlexeySotkin @bashbaug @mbelicki
sycl/doc/extensions/SPIRV/ @intel/dpcpp-spirv-doc-reviewers
sycl/doc/dev @bader @vladimirlaz

# Sub-groups
sycl/include/CL/sycl/detail/spirv.hpp @Pennycook @AlexeySachkov
sycl/include/sycl/ext/intel/group_algorithm.hpp @Pennycook @AlexeySachkov
sycl/include/sycl/ext/intel/sub_group.hpp @Pennycook @AlexeySachkov
sycl/include/sycl/ext/intel/sub_group_host.hpp @Pennycook @AlexeySachkov

# PI API
sycl/include/CL/sycl/detail/pi.def @smaslov-intel
sycl/include/CL/sycl/detail/pi.h @smaslov-intel
sycl/include/CL/sycl/detail/pi.hpp @smaslov-intel
sycl/include/CL/sycl/detail/pi* @smaslov-intel
sycl/plugins/ @smaslov-intel
sycl/source/detail/pi.cpp @smaslov-intel
sycl/source/detail/plugin.hpp @smaslov-intel
sycl/source/detail/posix_pi.cpp @smaslov-intel
sycl/source/detail/windows_pi.cpp @smaslov-intel
# Level Zero plugin
sycl/sycl/plugins/level_zero @intel/dpcpp-l0-pi-reviewers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladimirlaz, code review assignment is broken.
I think it's due to bugs in the .github/CODEOWNERS file.

sycl/sycl/plugins/level_zero -> sycl/plugins/level_zero?


# ESIMD CPU emulator plug-in
sycl/plugins/esimd_cpu/ @kbobrovs @smaslov-intel
sycl/plugins/esimd_cpu/ @intel/dpcpp-esimd-reviewers

# CUDA plugin
sycl/plugins/cuda/ @intel/llvm-reviewers-cuda

# Stream
sycl/include/CL/sycl/detail/stream_impl.hpp @againull
sycl/include/CL/sycl/stream.hpp @againull
sycl/source/detail/stream_impl.cpp @againull
sycl/source/stream.cpp @againull

# FPGA extensions
sycl/include/sycl/ext/intel/fpga_device_selector.hpp @MrSidims
sycl/include/sycl/ext/intel/fpga_extensions.hpp @MrSidims
sycl/include/sycl/ext/intel/fpga_reg.hpp @MrSidims
sycl/include/sycl/ext/intel/pipes.hpp @MrSidims
sycl/include/CL/sycl/pipes.hpp @MrSidims

# Reduction extension
sycl/include/sycl/ext/intel/reduction.hpp @v-klochkov

# Function pointers
sycl/include/sycl/ext/intel/function_pointer.hpp @AlexeySachkov
sycl/source/function_pointer.cpp @AlexeySachkov

# Half Type
sycl/include/CL/sycl/half_type.hpp @AlexeySachkov
sycl/source/half_type.cpp @AlexeySachkov

# XPTI instrumentation utilities
xpti/ @tovinkere @andykaylor @alexbatashev
xptifw/ @tovinkere @andykaylor @alexbatashev
xpti/ @tovinkere @intel/llvm-reviewers-runtime
xptifw/ @tovinkere @intel/llvm-reviewers-runtime

# DPC++ tools
llvm/**/append-file/ @mdtoguchi @AGindinson
llvm/**/file-table-tform/ @mlychkov @AlexeySachkov @kbobrovs
llvm/**/llvm-foreach/ @AlexeySachkov @Fznamznon
llvm/**/llvm-no-spir-kernel/ @AGindinson @AlexeySachkov
llvm/**/sycl-post-link/ @mlychkov @AlexeySachkov @kbobrovs
llvm/include/llvm/Support/PropertySetIO.h @mlychkov @AlexeySachkov @kbobrovs
llvm/lib/Support/PropertySetIO.cpp @mlychkov @AlexeySachkov @kbobrovs
llvm/unittests/Support/PropertySetIOTest.cpp @mlychkov @AlexeySachkov @kbobrovs
llvm/include/llvm/Support/SimpleTable.h @mlychkov @AlexeySachkov @kbobrovs
llvm/lib/Support/SimpleTable.cpp @mlychkov @AlexeySachkov @kbobrovs
llvm/unittests/Support/SimpleTableTest.cpp @mlychkov @AlexeySachkov @kbobrovs
llvm/lib/Support/Base64.cpp @mlychkov @AlexeySachkov @kbobrovs
llvm/ @intel/dpcpp-tools-reviewers

# Clang offload tools
clang/tools/clang-offload-bundler/ @mlychkov @sndmitriev @AlexeySachkov
clang/tools/clang-offload-wrapper/ @mlychkov @sndmitriev @AlexeySachkov @kbobrovs
clang/tools/clang-offload-deps/ @sndmitriev @mlychkov @AlexeySachkov
clang/tools/clang-offload-extract/ @sndmitriev @mlychkov @AlexeySachkov
clang/tools/clang-offload-*/ @intel/dpcpp-tools-reviewers

# Explicit SIMD
SYCLLowerIR/ @kbobrovs @sndmitriev @kychendev @v-klochkov
esimd/ @kbobrovs @v-klochkov @kychendev
sycl/include/sycl/ext/intel/experimental/esimd.hpp @kbobrovs @v-klochkov @kychendev
sycl/doc/extensions/ExplicitSIMD/ @kbobrovs @v-klochkov @kychendev

# ITT annotations
llvm/lib/Transforms/Instrumentation/SPIRITTAnnotations.cpp @MrSidims @vzakhari
llvm/include/llvm/Transforms/Instrumentation/SPIRITTAnnotations.h @MrSidims @vzakhari
llvm/test/Transforms/SPIRITTAnnotations/* @MrSidims @vzakhari

# Generic address space support for printf
llvm/lib/SYCLLowerIR/MutatePrintfAddrspace.cpp @intel/dpcpp-tools-reviewers
llvm/include/llvm/SYCLLowerIR/MutatePrintfAddrspace.h @intel/dpcpp-tools-reviewers
llvm/test/SYCLLowerIR/printf_addrspace/* @intel/dpcpp-tools-reviewers
SYCLLowerIR/ @intel/dpcpp-esimd-reviewers
esimd/ @intel/dpcpp-esimd-reviewers
sycl/include/sycl/ext/intel/experimental/esimd.hpp @intel/dpcpp-esimd-reviewers
sycl/doc/extensions/ExplicitSIMD/ @intel/dpcpp-esimd-reviewers