[CI] Provide libclc targets to build and test #5091
Conversation
|
LGTM, but will we need it after #5087 is merged? |
| if build_libclc: | ||
| llvm_enable_projects += ';libclc' | ||
| # CI Default conditionally appends to options, keep it at the bottom of | ||
| # args handling |
There was a problem hiding this comment.
@alexbatashev, @vladimirlaz, FYI.
When we originally discussed --ci-defaults option, I thought that these defaults can be overridden by additional options. E.g. --ci-defaults --option-X=val, so that if --ci-defaults sets --option-X, users can replace the default value.
Unfortunately, I don't see this requirement to be documented in the code and it seems to be not true for options modified inside this if-statement.
There was a problem hiding this comment.
@bader it’s a good point, we shall fix it in the future
* upstream/sycl: (725 commits) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078) [SYCL] Fix the test to not depend on a specific line. (intel#5092) [CI] Provide libclc targets to build and test (intel#5091) Fix build of `check-llvm-spirv` target after 8f8001a Force opt to use new pass manager in pr52289 test after c34d157 ...
| if libclc_amd_target_names not in libclc_targets_to_build: | ||
| libclc_targets_to_build += libclc_amd_target_names |
There was a problem hiding this comment.
I think to build libclc for AMD target, LLVM's AMDGPU target back-end must be built. @jchlanda, am I right?
There was a problem hiding this comment.
That was my guess as well, but I've just tried and LIBCLC_TARGETS_TO_BUILD:STRING=;amdgcn--;amdgcn--amdhsa builds fine with only LLVM_TARGETS_TO_BUILD:STRING=X86. Saying that I'm worried that if in future libclc uses more AMD specific code (for example builtins) it will not be possible. Enforcing AMDGPU backend seems like a wise thing to do moving forward.
Follow up to #5062
This PR ensures that
libclcis built and tested against:amdgcn--;amdgcn--amdhsanvptx64--;nvptx64--nvidiacl