[SYCL] Add intelfpga vendor header files #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domiyan
changed the title
bader
reviewed
Aug 16, 2019
|
@domiyan, please, sign new commits. |
…FPGA extensions Signed-off-by: Domi Yan <[email protected]>
domiyan
force-pushed
the
add_intelfpga_vendor_header_files
branch
from
ee66b62 to
897a620
Compare
|
@bader. Not sure how to modify sign on the exiting one. I created a new branch, applied the diff and force-pushed. |
bader
approved these changes
Aug 17, 2019
keryell
reviewed
Aug 19, 2019
|
|
||
| #pragma once | ||
| #include <CL/sycl/intel/fpga_device_selector.hpp> | ||
| #include <CL/sycl/intel/fpga_reg.hpp> |
| #include <CL/sycl/intel/fpga_device_selector.hpp> | ||
| ... | ||
| // force FPGA emulation device | ||
| cl::sycl::queue deviceQueue(cl::sycl::intel::fpga_emulator_selector{}); |
There was a problem hiding this comment.
Since you are using {}, replace the outer parenthesis too.
| @@ -0,0 +1,31 @@ | |||
| # FPGA reg | |||
|
|
|||
| Intel FPGA extension fpga_reg() is implemented in header file | |||
| Intel FPGA extension fpga_reg() is implemented in header file | ||
| `#include <CL/sycl/intel/fpga_extensions.hpp>`. | ||
|
|
||
| fpga_reg is used to help compiler infer that at least one register is on the corresponding data path. |
|
|
||
| ## Implementation | ||
|
|
||
| The implementation is a wrapper class to map fpga_reg function call to built-in \_\_builtin_intel_fpga_reg() |
There was a problem hiding this comment.
fpga_reg → fpga_reg()
__builtin_intel_fpga_reg() → __builtin_intel_fpga_reg()
mkinsner
reviewed
Aug 21, 2019
| namespace sycl { | ||
| namespace intel { | ||
|
|
||
| class platform_selector : public default_selector { |
There was a problem hiding this comment.
Should this derive from device_selector instead of default_selector?
There was a problem hiding this comment.
good point. I will fix this in next patch.
iclsrc
pushed a commit
that referenced
this pull request
Apr 2, 2025
This was added in OpenACC PR #511 in the 3.4 branch. From an AST/Sema perspective this is pretty trivial as the infrastructure for 'if' already exists, however the atomic construct needed to be taught to take clauses. This patch does that and adds some testing to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With FPGA header files, users have shortcuts to access FPGA device selector and FPGA extension (fpga_reg).
Example of using FPGA device selector.
#include <CL/sycl/intel/fpga_extensions.hpp>
...
cl::sycl::queue deviceQueue(cl::sycl::intel::fpga_selector{}); // this force fpga hardware device
...
Example of using FPGA extensions.
#include <CL/sycl/intel/fpga_extensions.hpp>
...
r[k] = cl::sycl::intel::fpga_reg(a[k]) + b[k];
...
Signed-off-by: Domi Yan [email protected]