[SYCL] Prohibit taking address of non-indirectly callable functions #5151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit a error when address of function not marked with `[[intel::device_indirectly_callable]]` attribute is taken. The error is emitted only if flag `-fsycl-allow-func-ptr` if passed.
|
/summary:run |
ESIMD doesn't yet support function pointers properly.
|
/summary:run |
|
I don't think SYCL :: DeprecatedFeatures/get_backend.cpp fail is related to the patch. It fails in runtime and was not reported in summary run. |
|
@intel/dpcpp-cfe-reviewers & @AlexeySachkov , could you please review this one? |
smanna12
reviewed
Jan 12, 2022
smanna12
reviewed
Jan 12, 2022
smanna12
reviewed
Jan 12, 2022
Fznamznon
commented
Jan 12, 2022
premanandrao
previously approved these changes
Jan 12, 2022
smanna12
reviewed
Jan 12, 2022
smanna12
reviewed
Jan 12, 2022
smanna12
reviewed
Jan 12, 2022
smanna12
reviewed
Jan 13, 2022
elizabethandrews
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit a error when address of function not marked with
[[intel::device_indirectly_callable]]attribute is taken. The error isemitted only if flag
-fsycl-allow-func-ptrif passed.