[SYCL] Remove old extension specifications #5381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these extensions were adopted into SYCL 2020, so they are no longer a language extension. The SYCL 2020 specification is a more accurate description of these features, so remove these old versions.
Pennycook
previously approved these changes
Jan 24, 2022
sycl/doc/extensions/KernelRHSAttributes/SYCL_INTEL_attribute_style.asciidoc
Show resolved
Hide resolved
sycl/doc/extensions/UnnamedKernelLambda/SYCL_INTEL_unnamed_kernel_lambda.asciidoc
Show resolved
Hide resolved
bader
previously approved these changes
Jan 25, 2022
This was also adopted into SYCL 2020.
gmlueck
changed the title
Pennycook
previously approved these changes
Jan 25, 2022
steffenlarsen
previously approved these changes
Jan 25, 2022
Add a table of the extensions that were incorporated into SYCL 2020.
|
Ping to reviewers: Could I get re-approvals now that I have added the table of removed extensions in "sycl/doc/extensions/removed/README.md" as @steffenlarsen proposed? |
steffenlarsen
approved these changes
Jan 31, 2022
bader
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these extensions were adopted into SYCL 2020, so they are no
longer a language extension. The SYCL 2020 specification is a more
accurate description of these features, so remove these old versions.