-
Notifications
You must be signed in to change notification settings - Fork 787
[Doc] Remove the OpenCL USM spec draft #5405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bashbaug, I would remove the document completely and put new status to the commit message. |
There could still be links to the previous spec draft so I would prefer not to remove it completely, but I definitely don't want to have stale content or maintain it in two places. Signposting to the final version seemed like a good compromise solution. What have we done in the past for extensions or other features after they are final? |
The OpenCL USM specification cl_intel_unified_shared memory is now final and is tracked on the Khronos OpenCL registry. Signed-off-by: Ben Ashbaugh <[email protected]>
4a767e0
to
1c65792
Compare
In some cases, we have a SYCL design document that points to the related OpenCL or SPIR-V extension specifications. For example, we do this in DeviceGlobal.md. In cases like that, we can update the link in the design doc to point to the final OpenCL/SPIR-C spec that is in the registry. In this case, there is no USM design doc, so there is no link to update. I think it's OK to just remove the OpenCL spec in this case with no signpost. It's not clear why people would go looking for an OpenCL extension specification in the llvm repo. |
To be clear, I'm fine removing the spec, but consider:
These all should be updated to refer to the extension specification on the registry instead, but it will take some time for these updates to occur. |
Yes, for me the top google hit is also the "intel/llvm" repo. However, the third hit is the Khronos registry. I could put a signpost in the new directory in "intel/llvm" that will hold the WIP OpenCL extension specifications. However, this will not be the same location that "cl_intel_unified_shared_memory.asciidoc" resided in before. Do we think that's useful? |
Could we maybe add a generic signpost to the effect of "if you're looking for a previous WIP draft that is now final, look for the final specificiations in the (Khronos registries? oneAPI docs?)"? I don't think this is OpenCL-specific, and we likely have (or will have soon) a bunch of SPIR-V extensions that should be tracked in Khronos repos rather than here. |
Yes, I like that. I'll add text like that to a README file in each of the folders that contain WIP OpenCL and SPIR-V specs. I'll also include links to the roots of the respective Khronos registries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmlueck, does it look okay to you?
The OpenCL USM specification is now final and tracked on the Khronos OpenCL registry. Rather than maintaining the content in both places, remove the OpenCL USM specification.
Signed-off-by: Ben Ashbaugh [email protected]