[SYCL][L0] Support buffer migration for contexts with multiple devices #5966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being fixed in intel/llvm-test-suite#976 |
|
/verify with intel/llvm-test-suite#976 |
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
againull
reviewed
Apr 8, 2022
Signed-off-by: Sergey V Maslov <[email protected]>
|
/verify with intel/llvm-test-suite#976 |
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
|
/verify with intel/llvm-test-suite#976 |
againull
reviewed
Apr 11, 2022
againull
reviewed
Apr 11, 2022
| PI_CALL(USMFreeHelper(Context, ZeHandle, true)); | ||
| break; | ||
| case allocation_t::free_native: | ||
| ZE_CALL(zeMemFree, (Context->ZeContext, ZeHandle)) |
There was a problem hiding this comment.
Please use helper which takes into account an option of tracking indirectly accessed memory.
Suggested change
| ZE_CALL(zeMemFree, (Context->ZeContext, ZeHandle)) | |
| if (auto Res = ZeMemFreeHelper(Context, ZeHandle, true)) | |
| return Res; |
Signed-off-by: Sergey V Maslov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes make SYCL buffer to work properly in contexts with multiple devices.
Instead of creating a single host allocation and using it from all devices (which is slow, at least) it is now maintaining device allocations in all used devices, and maintains migration of valid buffer data across these multiple device allocations.
E2E test is in intel/llvm-test-suite#976
Signed-off-by: Sergey V Maslov [email protected]