Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCl][L0] Buffer for multi-device context is using device allocation now #976

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

smaslov-intel
Copy link

Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel
Copy link
Author

/verify with intel/llvm#5966

@smaslov-intel smaslov-intel requested a review from againull April 9, 2022 02:09
@smaslov-intel
Copy link
Author

/verify with intel/llvm#5966

Comment on lines -93 to -96
char *Ptr = (char *)HostBuffer1;
for (int i = 0; i < 10; i++) {
assert(Ptr[i] == 'a');
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@againull : from the spec you crafted:

A SYCL buffer that is constructed with this interop API uses the Level Zero memory allocation for its full lifetime, and the contents of the Level Zero memory allocation are unspecified for the lifetime of the SYCL buffer. If the application modifies the contents of that Level Zero memory allocation during the lifetime of the SYCL buffer, the behavior is undefined.

@smaslov-intel
Copy link
Author

/verify with intel/llvm#5966

1 similar comment
@smaslov-intel
Copy link
Author

/verify with intel/llvm#5966

Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel
Copy link
Author

/verify with intel/llvm#5966

@smaslov-intel
Copy link
Author

FAIL: SYCL :: Basic/context-with-multiple-devices.cpp (114 of 877)
[2022-04-12T00:58:00.712Z] ******************** TEST 'SYCL :: Basic/context-with-multiple-devices.cpp' FAILED ********************
[2022-04-12T00:58:00.712Z] Script:
[2022-04-12T00:58:00.712Z] --
[2022-04-12T00:58:00.712Z] : 'RUN: at line 3'; /netbatch/donb3259726_00/runDir/jenkins-dir/workspace/SYCL_CI/intel/Lin/LLVM_Test_Suite/llvm.obj/bin/clang++ -fsycl -fintelfpga -fsycl-unnamed-lambda /netbatch/donb3259726_00/runDir/jenkins-dir/workspace/SYCL_CI/intel/Lin/LLVM_Test_Suite/llvm-test-suite/SYCL/Basic/context-with-multiple-devices.cpp -o /netbatch/donb3259726_00/runDir/jenkins-dir/workspace/SYCL_CI/intel/Lin/LLVM_Test_Suite/build/SYCL/Basic/Output/context-with-multiple-devices.cpp.tmp2.out
[2022-04-12T00:58:00.712Z] : 'RUN: at line 4'; env CL_CONFIG_CPU_EMULATE_DEVICES=2 /netbatch/donb3259726_00/runDir/jenkins-dir/workspace/SYCL_CI/intel/Lin/LLVM_Test_Suite/build/SYCL/Basic/Output/context-with-multiple-devices.cpp.tmp2.out
[2022-04-12T00:58:00.712Z] --
[2022-04-12T00:58:00.712Z] Exit Code: -11

I cannot reproduce this locally. @againull , @cperkinsintel any idea?

@cperkinsintel
Copy link

Basic/context-with-multiple-devices.cpp is a known failure we are trying to track down. I have a PR to disable it ( #983 ) however, I strongly suspect that if we disable it, the failure will simply show up somewhere else. Seems to be some sort of infrastructure problem. Not sure.

@againull againull merged commit 6ce8f20 into intel:intel Apr 12, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants