[SYCL] Image_accessor read with sampler for host device. #597
Conversation
| @@ -589,7 +589,8 @@ template <typename Type, int NumElements> class vec { | |||
| static constexpr size_t get_count() { return NumElements; } | |||
| static constexpr size_t get_size() { return sizeof(m_Data); } | |||
|
|
|||
| template <typename convertT, rounding_mode roundingMode> | |||
| template <typename convertT, | |||
| rounding_mode roundingMode = rounding_mode::automatic> | |||
There was a problem hiding this comment.
I'd like that too but it's not spec. Propose to clarify whether it is possible to do so.
There was a problem hiding this comment.
In table 4.98 the spec says:
automatic - Default rounding mode for the SYCL vec class element type, rtz (round toward zero) for integer types and rte(roundtonearesteven)forfloating-point types.
Is it not clear enough in the spec?
There was a problem hiding this comment.
Yes, that explains what automatic means for floating point types and for integer types. What behavior is expected.
But you change the API which is described in the specification.
I don't think it's a bad change. But if a user writes code with our SYCL, and uses what you wrote(cl::sycl::int4::template convert()), then his code may not be compiled with another SYCL that follows the specification.
template <typename convertT, rounding_mode roundingMode>
vec<convertT, numElements> convert() const;
There was a problem hiding this comment.
That is a good point. Do you think asking for a spec update is valid for this?
There was a problem hiding this comment.
Yes, I agree with this change in SYCL specification. In OpenCL when converting by default, a rounding model is not written.
garimagu
force-pushed
the
private/garimagu/readAPI_sampler2
branch
from
2ef9b66 to
0842fdf
Compare
|
Please only check the last 2 commits. The previous commits are being reviewed in another PR. |
care of conversion rules as per OpenCL spec 1.2 section 8.3. Addition of image_accessor_write_api.cpp test case. Signed-off-by: Garima Gupta <[email protected]>
Addition of test case for read API without a sampler. Checking is done if the read data is correct and as expected. Signed-off-by: Garima Gupta <[email protected]>
-Support added for sampler with NEAREST Filtering Mode. -Check if the results are consistent with the values read by CPU/GPU device using a test case. -Currently, the test case is enabled only for CPU. Seg faults on GPU. -Added a small test case for as() function in vec class. There is no efficient test case in CTS or in lit-tests. Signed-off-by: Garima Gupta <[email protected]>
garimagu
force-pushed
the
private/garimagu/readAPI_sampler2
branch
from
90ad879 to
702ad0e
Compare
|
Rebased, squashed the last commit, did change in the test to rectify the failure seen on Windows. |
|
Please check only the last commit: [SYCL] Image_accessor read with sampler for host device. |
The test must return a value larger than zero if an error occurs. The expected warning from the runtime has been actualized. Signed-off-by: Pavel Samolysov <[email protected]>
NOTE: PLEASE REVIEW ONLY THE LAST COMMIT.
THE FIRST 2 COMMITS ARE A PART OF REVIEW: #562