Skip to content

[SYCL] Fix host data allocation in USM test #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2019
Merged

[SYCL] Fix host data allocation in USM test #661

merged 1 commit into from
Sep 23, 2019

Conversation

bader
Copy link
Contributor

@bader bader commented Sep 20, 2019

No description provided.

@jbrodman jbrodman self-requested a review September 20, 2019 11:50
jbrodman
jbrodman previously approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@jbrodman jbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader
Copy link
Contributor Author

bader commented Sep 20, 2019

I'm 100% sure, my changes in allocator_vector LIT test can't break image_accessor_readsampler LIT test.
Most likely there is some UB introduced by #597.

@garimagu, please, take a look at this failure.

+@romanovvlad, +@alexeyvoronov

@garimagu
Copy link
Contributor

Created intel/llvm #664 for the change. I don't know why this error was not seen with #597

@bader bader requested a review from jbrodman September 21, 2019 04:37
@bader bader merged commit 18444c0 into intel:sycl Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanovvlad romanovvlad romanovvlad approved these changes

@jbrodman jbrodman Awaiting requested review from jbrodman

Assignees

@romanovvlad romanovvlad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bader @garimagu @jbrodman @romanovvlad