[SYCL][CUDA][libclc] Add software atomics implementations for lower sm versions #5998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm-test-suite#985 |
elizabethandrews
approved these changes
Apr 11, 2022
premanandrao
approved these changes
Apr 11, 2022
smanna12
approved these changes
Apr 11, 2022
|
Can this be merged? |
|
Test failures are unrelated.
|
pvchupin
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
May 3, 2022
Reduces sm version requirement for atomic_ref tests. Testing this properly would require duplicating all the atomic ref tests for sm_50 (as in this PR) and for sm_70 (for system scope atomics). That would duplicate all the slowest tests. To avoid significant increase of test running time I am instead removing testing for system atomics, which have relatively simple implementations. Tests intel/llvm#5998
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…lvm-test-suite#985) Reduces sm version requirement for atomic_ref tests. Testing this properly would require duplicating all the atomic ref tests for sm_50 (as in this PR) and for sm_70 (for system scope atomics). That would duplicate all the slowest tests. To avoid significant increase of test running time I am instead removing testing for system atomics, which have relatively simple implementations. Tests intel#5998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds software implementations for various atomics for sm versions blow ones where they are supported natively. Now all atomics, except for the ones using system scope are supported regardless of the sm version.
Now
SYCL_USE_NATIVE_FP_ATOMICSis also defined for CUDA by default.Closes #5936.
Tested by: intel/llvm-test-suite#985