[SYCL][libdevice] Simplify SYCL libdevice cmake file. #6037
Conversation
Signed-off-by: jinge90 <[email protected]>
|
/summary:run |
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Hi, @intel/llvm-reviewers-runtime Thanks very much. |
| add_devicelib_obj(libsycl-fallback-cassert SRC fallback-cassert.cpp DEP ${crt_obj_deps}) | ||
| add_devicelib_obj(libsycl-fallback-cstring SRC fallback-cstring.cpp DEP ${crt_obj_deps}) | ||
| add_devicelib_spv(libsycl-fallback-cassert SRC fallback-cassert.cpp DEP ${crt_obj_deps}) | ||
| add_devicelib_spv(libsycl-fallback-cstring SRC fallback-cstring.cpp DEP ${crt_obj_deps}) | ||
|
|
||
| set(complex_obj_deps device_complex.h device.h sycl-compiler) | ||
| add_devicelib_obj(libsycl-complex SRC complex_wrapper.cpp DEP ${complex_obj_deps}) | ||
| add_devicelib_obj(libsycl-complex-fp64 SRC complex_wrapper_fp64.cpp DEP ${complex_obj_deps} ) | ||
| add_devicelib_obj(libsycl-fallback-complex SRC fallback-complex.cpp DEP ${complex_obj_deps}) | ||
| add_devicelib_obj(libsycl-fallback-complex-fp64 SRC fallback-complex-fp64.cpp DEP ${complex_obj_deps} ) | ||
| add_devicelib_spv(libsycl-fallback-complex SRC fallback-complex.cpp DEP ${complex_obj_deps}) | ||
| add_devicelib_spv(libsycl-fallback-complex-fp64 SRC fallback-complex-fp64.cpp DEP ${complex_obj_deps}) | ||
|
|
||
| set(cmath_obj_deps device_math.h device.h sycl-compiler) | ||
| add_devicelib_obj(libsycl-cmath SRC cmath_wrapper.cpp DEP ${cmath_obj_deps}) | ||
| add_devicelib_obj(libsycl-cmath-fp64 SRC cmath_wrapper_fp64.cpp DEP ${cmath_obj_deps} ) | ||
| add_devicelib_obj(libsycl-fallback-cmath SRC fallback-cmath.cpp DEP ${cmath_obj_deps}) | ||
| add_devicelib_obj(libsycl-fallback-cmath-fp64 SRC fallback-cmath-fp64.cpp DEP ${cmath_obj_deps}) | ||
| add_devicelib_spv(libsycl-fallback-cmath SRC fallback-cmath.cpp DEP ${cmath_obj_deps}) | ||
| add_devicelib_spv(libsycl-fallback-cmath-fp64 SRC fallback-cmath-fp64.cpp DEP ${cmath_obj_deps}) | ||
|
|
||
| set(itt_obj_deps device_itt.h spirv_vars.h device.h sycl-compiler) | ||
| add_devicelib_obj(libsycl-itt-stubs SRC itt_stubs.cpp DEP ${itt_obj_deps}) | ||
| add_devicelib_obj(libsycl-itt-compiler-wrappers SRC itt_compiler_wrappers.cpp DEP ${itt_obj_deps}) | ||
| add_devicelib_obj(libsycl-itt-user-wrappers SRC itt_user_wrappers.cpp DEP ${itt_obj_deps}) |
There was a problem hiding this comment.
I think that having one extra function/macro/etc. that creates both spv and obj simultaneously will make this code easier to read. Can you please implement that?
There was a problem hiding this comment.
Also, I would be slightly in favor of different grouping - by how we we compile/what type (itt/other obj/fallback(both obj/spv). The reason is that due to #5435 we need to link spv files with itt symbols and so itt should appear before other commands (at least logically, not sure if cmake requires that as well).
There was a problem hiding this comment.
I think that having one extra function/macro/etc. that creates both spv and obj simultaneously will make this code easier to read. Can you please implement that?
The function combining obj and spv creation is added and the grouping is updated too.
Thanks very much.
Signed-off-by: jinge90 <[email protected]>
1. itt objs 2. other objs 3. other spvs Signed-off-by: jinge90 <[email protected]>
|
Fail is unrelated. Will be addressed in #6059. |
Signed-off-by: jinge90 [email protected]