Skip to content

[NFC][SYCL] Refactor libdevice/cmake/modules/SYCLLibdevice.cmake #6049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[NFC][SYCL] Refactor libdevice/cmake/modules/SYCLLibdevice.cmake #6049

wants to merge 2 commits into from

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner April 22, 2022 20:01
@pvchupin pvchupin requested a review from jinge90 April 22, 2022 20:02
@pvchupin pvchupin requested a review from tcreech-intel April 22, 2022 20:05
@jinge90
Copy link
Contributor

jinge90 commented Apr 23, 2022 •
edited
Loading

Hi, @aelovikov-intel and @pvchupin
It seems that we have done similar things, I have submitted a patch earlier this week and haven't been reviewed: #6037 and I also included some typo fix in that patch, pre-ci has passed except one test which should be an infrastructure issue. This PR does almost same things as my previous PR, do you mind reviewing my previous PR and close this one? So, we don't need to submit a new patch for typo issue in libdevice sources.
Thanks very much.

@aelovikov-intel aelovikov-intel deleted the sycllibdevice-cmake-refactor branch August 25, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvchupin pvchupin pvchupin approved these changes

@steffenlarsen steffenlarsen Awaiting requested review from steffenlarsen steffenlarsen is a code owner automatically assigned from intel/llvm-reviewers-runtime

@jinge90 jinge90 Awaiting requested review from jinge90

@tcreech-intel tcreech-intel Awaiting requested review from tcreech-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @jinge90 @pvchupin