Skip to content

[SYCL][DOC] Update buffer_location spec to unblock USM host/shared allocations #6219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

tiwaria1
Copy link
Contributor

@tiwaria1 tiwaria1 commented May 31, 2022

Spec states that the runtime buffer_location property will not have an effect on shared/host allocations. This is incorrect as the property is meant to be used with host/shared allocations with the same behavior as device allocations.

#6218
#6220

@tiwaria1 tiwaria1 requested a review from GarveyJoe May 31, 2022 18:45
@tiwaria1 tiwaria1 marked this pull request as ready for review May 31, 2022 18:45
@tiwaria1 tiwaria1 requested a review from a team as a code owner May 31, 2022 18:45
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nitpicks, otherwise the changes LGTM.

@tiwaria1 tiwaria1 requested a review from steffenlarsen June 1, 2022 13:25
@tiwaria1
Copy link
Contributor Author

tiwaria1 commented Jun 1, 2022

Thanks Steffen!

@tiwaria1
Copy link
Contributor Author

tiwaria1 commented Jun 3, 2022

@steffenlarsen Can we get this one merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants