Skip to content

[SYCL] Align USM buffer location implementation for malloc_device with malloc_shared #6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2022
Merged

[SYCL] Align USM buffer location implementation for malloc_device with malloc_shared #6269

merged 2 commits into from
Jun 8, 2022

Conversation

pcolberg
Copy link
Contributor

@pcolberg pcolberg commented Jun 7, 2022 •
edited
Loading

Use the same call to USMDeviceAlloc with a possibly empty property list
in all cases, to allow for straight-forward extension with future properties.

Query buffer location extension only if buffer location property is passed.

This amends #5634

See also #6220

@pcolberg pcolberg requested a review from a team as a code owner June 7, 2022 23:56
@pcolberg pcolberg marked this pull request as draft June 8, 2022 01:16
pcolberg added 2 commits June 7, 2022 22:33
@pcolberg
[SYCL][L0] Allow empty properties in USMDeviceAlloc
b98b8bb
@pcolberg
[SYCL] Align USM buffer location implementation for malloc_device wit…
8d70973 
…h malloc_shared

Use the same call to USMDeviceAlloc with an empty property list in all
cases, to allow for straight-forward extension with future properties.

Query buffer location extension only if buffer location property is passed.

This amends #5634

See also #6220
@pcolberg pcolberg marked this pull request as ready for review June 8, 2022 03:12
@pcolberg pcolberg requested a review from a team as a code owner June 8, 2022 03:12
steffenlarsen
steffenlarsen approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pcolberg
Copy link
Contributor Author

pcolberg commented Jun 8, 2022

@intel/llvm-gatekeepers This is ready for merge 🙂

@steffenlarsen steffenlarsen merged commit 9f61c8e into intel:sycl Jun 8, 2022
@pcolberg pcolberg deleted the usm_malloc_device_align_malloc_shared branch June 8, 2022 15:23
@pcolberg pcolberg mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees

@tiwaria1 tiwaria1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pcolberg @smaslov-intel @aelovikov-intel @steffenlarsen @tiwaria1