Skip to content

[SYCL][libdevice] Add missing dependency of sycl-compiler for imf #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jun 18, 2022

Signed-off-by: jinge90 [email protected]

This patch aims to fix post-commit issue for #6312
Building libimf SYCL device library depends on sycl-compiler

@jinge90 jinge90 requested a review from a team as a code owner June 18, 2022 07:52
@jinge90
Copy link
Contributor Author

jinge90 commented Jun 18, 2022

Hi, @pvchupin
Based on post-commit log: https://github.com/intel/llvm/actions/runs/2518694462
We tried to build imf fallback spv when llvm-spirv is not available. I checked the cmake and found the dependency on sycl-compiler is not added for imf SYCL device library.
Is there any way to run post-commit test suite in github PR review web page?
Thanks very much.

@pvchupin pvchupin merged commit 5d46fd2 into intel:sycl Jun 19, 2022
@pvchupin
Copy link
Contributor

@jinge90, as far as I know there is no way to push post-commit testing for unmerged PR at this point.
I'm going to merge this one. Please watch post-commit.

@jinge90
Copy link
Contributor Author

jinge90 commented Jun 19, 2022

Hi, @pvchupin
Post commit already passed.

Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants