Skip to content

[SYCL][libdevice] Add missing dependency of sycl-compiler for imf #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions libdevice/cmake/modules/SYCLLibdevice.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -150,23 +150,23 @@ add_custom_command(OUTPUT ${spv_binary_dir}/libsycl-fallback-imf.spv
${compile_opts} -I ${CMAKE_CURRENT_SOURCE_DIR}/imf
${imf_fp32_fallback_src}
-o ${spv_binary_dir}/libsycl-fallback-imf.spv
DEPENDS ${imf_fallback_fp32_deps} get_imf_fallback_fp32
DEPENDS ${imf_fallback_fp32_deps} get_imf_fallback_fp32 sycl-compiler
VERBATIM)

add_custom_command(OUTPUT ${obj_binary_dir}/libsycl-fallback-imf.${lib-suffix}
COMMAND ${clang} -fsycl -c
${compile_opts} ${sycl_targets_opt}
${imf_fp32_fallback_src} -I ${CMAKE_CURRENT_SOURCE_DIR}/imf
-o ${obj_binary_dir}/libsycl-fallback-imf.${lib-suffix}
DEPENDS ${imf_fallback_fp32_deps} get_imf_fallback_fp32
DEPENDS ${imf_fallback_fp32_deps} get_imf_fallback_fp32 sycl-compiler
VERBATIM)

add_custom_command(OUTPUT ${obj_binary_dir}/fallback-imf-fp32-host.${lib-suffix}
COMMAND ${clang} -c -D__LIBDEVICE_HOST_IMPL__
-I ${CMAKE_CURRENT_SOURCE_DIR}/imf
${imf_fp32_fallback_src}
-o ${obj_binary_dir}/fallback-imf-fp32-host.${lib-suffix}
DEPENDS ${imf_fallback_fp32_deps} get_imf_fallback_fp32
DEPENDS ${imf_fallback_fp32_deps} get_imf_fallback_fp32 sycl-compiler
VERBATIM)

add_custom_target(get_imf_fallback_fp64 DEPENDS ${imf_fp64_fallback_src})
Expand All @@ -175,23 +175,23 @@ add_custom_command(OUTPUT ${spv_binary_dir}/libsycl-fallback-imf-fp64.spv
${compile_opts} -I ${CMAKE_CURRENT_SOURCE_DIR}/imf
${imf_fp64_fallback_src}
-o ${spv_binary_dir}/libsycl-fallback-imf-fp64.spv
DEPENDS ${imf_fallback_fp64_deps} get_imf_fallback_fp64
DEPENDS ${imf_fallback_fp64_deps} get_imf_fallback_fp64 sycl-compiler
VERBATIM)

add_custom_command(OUTPUT ${obj_binary_dir}/libsycl-fallback-imf-fp64.${lib-suffix}
COMMAND ${clang} -fsycl -c -I ${CMAKE_CURRENT_SOURCE_DIR}/imf
${compile_opts} ${sycl_targets_opt}
${imf_fp64_fallback_src}
-o ${obj_binary_dir}/libsycl-fallback-imf-fp64.${lib-suffix}
DEPENDS ${imf_fallback_fp64_deps} get_imf_fallback_fp64
DEPENDS ${imf_fallback_fp64_deps} get_imf_fallback_fp64 sycl-compiler
VERBATIM)

add_custom_command(OUTPUT ${obj_binary_dir}/fallback-imf-fp64-host.${lib-suffix}
COMMAND ${clang} -c -D__LIBDEVICE_HOST_IMPL__
-I ${CMAKE_CURRENT_SOURCE_DIR}/imf
${imf_fp64_fallback_src}
-o ${obj_binary_dir}/fallback-imf-fp64-host.${lib-suffix}
DEPENDS ${imf_fallback_fp64_deps} get_imf_fallback_fp64
DEPENDS ${imf_fallback_fp64_deps} get_imf_fallback_fp64 sycl-compiler
VERBATIM)

add_custom_target(imf_fallback_fp32_spv DEPENDS ${spv_binary_dir}/libsycl-fallback-imf.spv)
Expand Down Expand Up @@ -230,7 +230,7 @@ add_custom_target(imf_host_obj
${obj_binary_dir}/fallback-imf-fp32-host.${lib-suffix}
${obj_binary_dir}/imf-fp64-host.${lib-suffix}
${obj_binary_dir}/fallback-imf-fp64-host.${lib-suffix}
DEPENDS imf_fp32_host_obj imf_fallback_fp32_host_obj imf_fp64_host_obj imf_fallback_fp64_host_obj
DEPENDS imf_fp32_host_obj imf_fallback_fp32_host_obj imf_fp64_host_obj imf_fallback_fp64_host_obj sycl-compiler
VERBATIM)
add_dependencies(libsycldevice-obj imf_host_obj)
install(FILES ${spv_binary_dir}/libsycl-fallback-imf.spv
Expand All @@ -243,4 +243,3 @@ install(FILES ${obj_binary_dir}/libsycl-fallback-imf.${lib-suffix}
${obj_binary_dir}/${devicelib_host_static}
DESTINATION ${install_dest_lib}
COMPONENT libsycldevice)