Skip to content

[SYCL][ESIMD] Fix an issue causing incorrect half conversion under ESIMD emulator #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

fineg74
Copy link
Contributor

@fineg74 fineg74 commented Aug 17, 2022

The purpose of this PR is to fix an incorrect half conversion issue under ESIMD emulator

@fineg74
Copy link
Contributor Author

fineg74 commented Aug 17, 2022

Complementary test PR: intel/llvm-test-suite#1155

@fineg74
Copy link
Contributor Author

fineg74 commented Aug 17, 2022

/verify with intel/llvm-test-suite#1155

1 similar comment
@fineg74
Copy link
Contributor Author

fineg74 commented Aug 17, 2022

/verify with intel/llvm-test-suite#1155

@fineg74
Copy link
Contributor Author

fineg74 commented Aug 17, 2022

SYCL / Linux / OCL x64 LLVM Test Suite failure is not related to the fix as the test doesn't contain any half types.
The rest of test failures are related to tests that used to fail in esimd emulator but passing now. It is addressed in test PR

@dongkyunahn-intel dongkyunahn-intel self-requested a review August 17, 2022 18:23
dongkyunahn-intel added a commit to dongkyunahn-intel/llvm-test-suite that referenced this pull request Aug 17, 2022
- Four half-type tests under ESIMD_EMULATOR backend are enabled as fix for
incorrect half-type conversion problem is to be merged -
intel/llvm#6592

- simd_view_select_2d_fp.cpp is enabled here too as it was missed from
PR intel#1008
@kbobrovs
Copy link
Contributor

@fineg74, there are test failures - please explain in the comment. I see
[2022-08-17T19:00:14.604Z] Failed Tests (3):
[2022-08-17T19:00:14.604Z] SYCL :: ESIMD/api/slm_gather_scatter_heavy.cpp
[2022-08-17T19:00:14.604Z] SYCL :: Plugin/level_zero_batch_event_status.cpp
[2022-08-17T19:00:14.604Z] SYCL :: USM/depends_on.cpp

@kbobrovs
Copy link
Contributor

SYCL / Linux / OCL x64 LLVM Test Suite failure is not related to the fix as the test doesn't contain any half types. The rest of test failures are related to tests that used to fail in esimd emulator but passing now. It is addressed in test PR

Thanks, could you please provide some details which of the tests fails for which reason (or is unrelated)?

@fineg74
Copy link
Contributor Author

fineg74 commented Aug 18, 2022

SYCL / Linux / OCL x64 LLVM Test Suite failure is not related to the fix as the test doesn't contain any half types. The rest of test failures are related to tests that used to fail in esimd emulator but passing now. It is addressed in test PR

Thanks, could you please provide some details which of the tests fails for which reason (or is unrelated)?

The actual failing test is XPTI/kernel/content.cpp and the error is some test execution. It is not related to the fix since fix is specific to half type that is executed on emulator. This test does not contain any half type data so the failure is not related to the fix

@fineg74
Copy link
Contributor Author

fineg74 commented Aug 18, 2022

/verify with intel/llvm-test-suite#1155

@kbobrovs kbobrovs merged commit 6143e55 into intel:sycl Aug 18, 2022
@kbobrovs
Copy link
Contributor

@dongkyunahn-intel, please update the tests:

Linux / ESIMD Emu LLVM Test Suite
Unexpectedly Passed Tests (5):
SYCL :: api/bin_and_cmp_ops_heavy.cpp
SYCL :: api/simd_memory_access.cpp
SYCL :: api/simd_view_select_2d_fp.cpp
SYCL :: api/slm_gather_scatter_heavy.cpp
SYCL :: api/unary_ops_heavy.cpp

@fineg74 fineg74 deleted the HalfConversion branch August 18, 2022 16:26
@dongkyunahn-intel
Copy link
Contributor

@dongkyunahn-intel, please update the tests:

Linux / ESIMD Emu LLVM Test Suite Unexpectedly Passed Tests (5): SYCL :: api/bin_and_cmp_ops_heavy.cpp SYCL :: api/simd_memory_access.cpp SYCL :: api/simd_view_select_2d_fp.cpp SYCL :: api/slm_gather_scatter_heavy.cpp SYCL :: api/unary_ops_heavy.cpp

@kbobrovs , it's already posted - intel/llvm-test-suite#1155

pvchupin pushed a commit to intel/llvm-test-suite that referenced this pull request Aug 18, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants