-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL][ESIMD] Fix an issue causing incorrect half conversion under ESIMD emulator #6592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Complementary test PR: intel/llvm-test-suite#1155 |
/verify with intel/llvm-test-suite#1155 |
1 similar comment
/verify with intel/llvm-test-suite#1155 |
SYCL / Linux / OCL x64 LLVM Test Suite failure is not related to the fix as the test doesn't contain any half types. |
- Four half-type tests under ESIMD_EMULATOR backend are enabled as fix for incorrect half-type conversion problem is to be merged - intel/llvm#6592 - simd_view_select_2d_fp.cpp is enabled here too as it was missed from PR intel#1008
@fineg74, there are test failures - please explain in the comment. I see |
Thanks, could you please provide some details which of the tests fails for which reason (or is unrelated)? |
The actual failing test is XPTI/kernel/content.cpp and the error is some test execution. It is not related to the fix since fix is specific to half type that is executed on emulator. This test does not contain any half type data so the failure is not related to the fix |
/verify with intel/llvm-test-suite#1155 |
@dongkyunahn-intel, please update the tests: Linux / ESIMD Emu LLVM Test Suite |
@kbobrovs , it's already posted - intel/llvm-test-suite#1155 |
Complementary compiler PR: intel/llvm#6592
…lvm-test-suite#1155) Complementary compiler PR: intel#6592
The purpose of this PR is to fix an incorrect half conversion issue under ESIMD emulator