[SYCL][ESIMD] Test half type conversion under ESIMD emulator #1155
Conversation
| // TODO: esimd_emulator fails due to outdated memory intrinsic | ||
| // XFAIL: esimd_emulator | ||
| // RUN: %clangxx -fsycl %s -o %t.out | ||
| ``````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````````` // RUN: %clangxx -fsycl %s -o %t.out |
|
@fineg74 , one more test (ext_math.cpp) can be enabled and one test (svm_gather_scatter.cpp) needs to be changed for half-type support. Can I add a commit for the fix in this PR? |
I see it is enabled for emulator already in my branch. |
| << q.get_device().get_info<::sycl::info::device::name>() | ||
| << "\n"; | ||
| auto acc = buf.template get_access<access::mode::read_write>(cgh); | ||
| cgh.single_task<test_id<Ty>>([=]() SYCL_ESIMD_KERNEL { |
There was a problem hiding this comment.
non-blocking comment. This should work properly without explicit name set:
| cgh.single_task<test_id<Ty>>([=]() SYCL_ESIMD_KERNEL { | |
| cgh.single_task([=]() SYCL_ESIMD_KERNEL { |
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include <CL/sycl.hpp> |
There was a problem hiding this comment.
Please don't use CL. There is an ongoing activity to replace CL with sycl. See: #1078
|
@kbobrovs, please always merge test changes together with compiler changes. These tests fail now in pre-commit PRs. |
right, sorry - this time took a while. |
) Complementary compiler PR: intel/llvm#6592
…lvm-test-suite#1155) Complementary compiler PR: intel#6592
Complementary compiler PR: intel/llvm#6592