[SYCL][ABI-Break] Support accessor property interface #6614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL 2020 defines a common property interface for accessor and host_accessor. Currently the DPC++ implementation of these classes take property list as a constructor argument but does not store them. In order to add the remaining interfaces the property lists must be stored on accessor and host_accessor, which is likely to break ABI.
KornevNikita
added a commit
to KornevNikita/llvm-test-suite
that referenced
this pull request
Aug 19, 2022
SYCL 2020 defines a common property interface for accessor and host_accessor. SYCL patch: intel/llvm#6614
|
/verify with intel/llvm-test-suite#1165 |
|
/verify with intel/llvm-test-suite#1165 |
|
/verify with intel/llvm-test-suite#1165 |
romanovvlad
reviewed
Aug 22, 2022
romanovvlad
reviewed
Aug 22, 2022
|
/verify with intel/llvm-test-suite#1165 |
|
/verify with intel/llvm-test-suite#1165 |
steffenlarsen
pushed a commit
that referenced
this pull request
Aug 23, 2022
As discussed here #6614 has_property() version for non compile-time-properties should be marked as `noexcept`.
|
/verify with intel/llvm-test-suite#1165 |
|
@romanovvlad @steffenlarsen @AlexeySachkov applied all suggestions, take one more look please. llvm-test-suite failure is not related to this patch. |
AlexeySachkov
previously approved these changes
Aug 24, 2022
steffenlarsen
approved these changes
Aug 25, 2022
steffenlarsen
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Aug 26, 2022
SYCL 2020 defines a common property interface for accessor and host_accessor. SYCL patch: intel/llvm#6614
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
SYCL 2020 defines a common property interface for accessor and host_accessor. SYCL patch: intel#6614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL 2020 defines a common property interface for accessor and host_accessor.
Currently the DPC++ implementation of these classes take property list as a
constructor argument but does not store them. In order to add the remaining
interfaces the property lists must be stored on accessor and host_accessor,
which is likely to break ABI.