[SYCL][ABI-break] Introduce fusion properties #6619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces properties for accessors and buffers related to kernel fusion. Stores the value of the property in the accessor host implementation (AccessorHostImpl), which is an ABI-breaking change.
|
Probably, this patch needs to be rebased on the work being done in #6614. |
Agreed, thanks for pointing this out. If the implementation and ABI-breaking change in #6614 would already allow to store all runtime-properties in the |
|
Closing this, as the ABI-breaking changes are superseded by #6614, because their implementation allows to store all runtime-properties on accessors, not just the fusion-specific. The remaining changes in this PR can be introduced properly together with the rest of kernel fusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces properties for accessors and buffers related to the kernel fusion extension proposal.
Stores the value of the property in the accessor host implementation (
AccessorImplHost), which is an ABI-breaking change. The property is only needed by the runtime on the host side, so it is not stored on the device side.This is of course not a complete port of the kernel fusion extension. However, as storing the corresponding properties that can be attached to
accessorrequires an ABI-breaking change, we propose this change for early integration while the ABI-breaking window is still open.