[SYCL] Make device and platform default to default_selector_v #6624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL2020 changes default constructors of device and platform to pick the objects associated with the device returned by default_selector_v rather than the host device. This commit changes these default constructors to adhere to this behaviour. Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1169 |
Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1169 |
romanovvlad
approved these changes
Aug 23, 2022
|
/verify with intel/llvm-test-suite#1169 |
1 similar comment
|
/verify with intel/llvm-test-suite#1169 |
|
Verification passed on Linux. Failures in verification on Windows do not include any of the tests from intel/llvm-test-suite#1169 and the same tests fail in verification on other PRs (example: #6639) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL2020 changes default constructors of device and platform to pick the objects associated with the device returned by
default_selector_vrather than the host device. This commit changes these default constructors to adhere to this behaviour.