Skip to content

[SYCL] Make intel specific device info descriptors namespace qualified #6639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 9, 2022

Conversation

raaiq1
Copy link
Contributor

@raaiq1 raaiq1 commented Aug 24, 2022

Conforming to SYCL 2020 specification section 6.3.1 and 4.6.4.2, to make extension information descriptors templated and within the correct namespace.

-Also moved deprecated info descriptors for device into separate file

-Changed namespace of the recently added device memory extension to ext::intel::info::device

@raaiq1 raaiq1 marked this pull request as ready for review August 24, 2022 19:43
@raaiq1 raaiq1 requested review from a team as code owners August 24, 2022 19:43
@raaiq1 raaiq1 requested a review from steffenlarsen August 24, 2022 19:43
@raaiq1
Copy link
Contributor Author

raaiq1 commented Aug 24, 2022

/verify with intel/llvm-test-suite#1178

@raaiq1 raaiq1 changed the title [SYCL] Make intel specific device info descriptors properly namespace qualified [SYCL] Make intel specific device info descriptors namespace qualified Aug 24, 2022
@raaiq1 raaiq1 marked this pull request as draft August 24, 2022 20:16
@raaiq1 raaiq1 marked this pull request as ready for review August 24, 2022 22:02
@raaiq1 raaiq1 marked this pull request as draft August 24, 2022 22:02
gmlueck
gmlueck previously approved these changes Aug 26, 2022
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec changes look good.

@raaiq1
Copy link
Contributor Author

raaiq1 commented Aug 26, 2022

/verify with intel/llvm-test-suite#1178

raaiq1 added 2 commits August 31, 2022 10:40
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
@raaiq1
Copy link
Contributor Author

raaiq1 commented Aug 31, 2022

/verify with intel/llvm-test-suite#1178

@raaiq1 raaiq1 marked this pull request as ready for review September 1, 2022 13:36
Signed-off-by: Rauf, Rana <[email protected]>
@raaiq1 raaiq1 requested a review from a team as a code owner September 6, 2022 19:28
@raaiq1
Copy link
Contributor Author

raaiq1 commented Sep 6, 2022

/verify with intel/llvm-test-suite#1178

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raaiq1
Copy link
Contributor Author

raaiq1 commented Sep 9, 2022

Failures have dependency on this PR or are unrelated.

@againull againull merged commit 0f4a0f3 into intel:sycl Sep 9, 2022
@raaiq1 raaiq1 deleted the info_namespace branch September 14, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants