[SYCL] Fix bugs in PI Mock #6852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-semenov
approved these changes
Sep 22, 2022
steffenlarsen
approved these changes
Sep 23, 2022
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Sep 23, 2022
intel#6852 incidentally used a non-constexpr solution for determining the size of a string, which causes failures in select build configurations. This commit amends this by using sizeof on a static array of characters instead of std::strlen. Signed-off-by: Larsen, Steffen <[email protected]>
|
Post-commit failures should be fixed with #6866. |
romanovvlad
pushed a commit
that referenced
this pull request
Sep 23, 2022
#6852 incidentally used a non-constexpr solution for determining the size of a string, which causes failures in select build configurations. This commit amends this by using sizeof on a static array of characters instead of std::strlen. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.