Skip to content

[SYCL] Fix constexpr string size in mock plugin #6866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

steffenlarsen
Copy link
Contributor

#6852 incidentally used a non-constexpr solution for determining the size of a string, which causes failures in select build configurations. This commit amends this by using sizeof on a static array of characters instead of std::strlen.

intel#6852 incidentally used a
non-constexpr solution for determining the size of a string, which
causes failures in select build configurations. This commit amends this
by using sizeof on a static array of characters instead of std::strlen.

Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@romanovvlad romanovvlad merged commit c2c6baf into intel:sycl Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants