[SYCL] Implement sycl_ext_intel_device_architecture for AOT #7008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm-vodopyanov
added a commit
to dm-vodopyanov/llvm-test-suite
that referenced
this pull request
Oct 12, 2022
|
/verify with intel/llvm-test-suite#1322 |
|
/verify with intel/llvm-test-suite#1322 |
sergey-semenov
approved these changes
Oct 13, 2022
sycl/include/sycl/ext/intel/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/intel/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
KornevNikita
approved these changes
Oct 20, 2022
sycl/unittests/Extensions/DeviceArchitectureOneArchSelected.cpp
Outdated
Show resolved
Hide resolved
dm-vodopyanov
commented
Oct 20, 2022
sycl/unittests/Extensions/DeviceArchitectureOneArchSelected.cpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/intel/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/unittests/Extensions/DeviceArchitectureOneArchSelected.cpp
Outdated
Show resolved
Hide resolved
sycl/unittests/Extensions/DeviceArchitectureOneArchSelected.cpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/intel/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/intel/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sergey-semenov
approved these changes
Oct 21, 2022
steffenlarsen
approved these changes
Oct 21, 2022
| fnTrue(args...); | ||
| return if_architecture_helper<false>{}; | ||
| } else { | ||
| (void)fnTrue; |
There was a problem hiding this comment.
Suggested change
| (void)fnTrue; | |
| std::ignore = fnTrue; |
Nit; just to be a little more modern.
There was a problem hiding this comment.
Sure, thanks! Will change it in another patch
|
@dm-vodopyanov, there is post commit issue on windows, can you have a look? https://github.com/intel/llvm/actions/runs/3298798512/jobs/5441377909 |
dm-vodopyanov
added a commit
to dm-vodopyanov/llvm
that referenced
this pull request
Oct 24, 2022
The spec was partially implemented in intel#7008
steffenlarsen
pushed a commit
that referenced
this pull request
Oct 24, 2022
dm-vodopyanov
added a commit
to intel/llvm-test-suite
that referenced
this pull request
Oct 26, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://github.com/intel/llvm/blob/7f2b17ed5b54271fb115cad02d40bae98b2c0454/sycl/doc/design/DeviceIf.md
Tests: intel/llvm-test-suite#1322