Skip to content

Move sycl_ext_intel_device_architecture to experimental folder #7155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

Move sycl_ext_intel_device_architecture to experimental folder #7155

merged 1 commit into from
Oct 24, 2022

Conversation

dm-vodopyanov
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov commented Oct 24, 2022 •
edited
Loading

The spec was partially implemented in #7008

@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner October 24, 2022 11:31
@gmlueck
Copy link
Contributor

gmlueck commented Oct 24, 2022

The spec was partially implemented in #7008

I what way is the implementation partial. What is not implemented yet?

@dm-vodopyanov
Copy link
Contributor Author

I what way is the implementation partial. What is not implemented yet?

Future direction part is not yet implemented. But everything which is currently in the Specification section - is implemented.

@gmlueck
Copy link
Contributor

gmlueck commented Oct 24, 2022

I was just reviewing the tests for this feature, and I saw this:

TODO: remove w/a with "-D__SYCL_TARGET_INTEL_X86_64__ after bug in compiler

So, it looks like -fsycl-targets=spir64_x86_64 is not implemented yet? Can we implement that before moving the extension specification out of "proposed"?

@dm-vodopyanov
Copy link
Contributor Author

So, it looks like -fsycl-targets=spir64_x86_64 is not implemented yet? Can we implement that before moving the extension specification out of "proposed"?

Oh, yes, I meant that headers part is done. Tagging @mdtoguchi who is working on the fix.

@dm-vodopyanov
Copy link
Contributor Author

Fix for -fsycl-targets=... was merged: #7108
Will remove w/a from the tests.

@steffenlarsen steffenlarsen merged commit 5d233ee into intel:sycl Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlueck gmlueck gmlueck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dm-vodopyanov @gmlueck @steffenlarsen