[SYCL] MacOS support for os_util #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhammond
force-pushed
the
macosx-os_util-support
branch
from
3f573ad to
08c0ed5
Compare
AGindinson
reviewed
Oct 28, 2019
jeffhammond
force-pushed
the
macosx-os_util-support
branch
from
08c0ed5 to
d4cab62
Compare
romanovvlad
reviewed
Oct 30, 2019
|
There is unresolved comment. |
|
I think a commit is missing being signed (-s) |
|
@jbrodman Attempts to sign the more recent commits is proving impossible. Suggestions? |
Slight modifications to the original implementation by Alexander Batashev. run clang-format Signed-off-by: Hammond, Jeff R <[email protected]> Signed-off-by: Alexander Batashev <[email protected] > Co-Authored-By: Romanov Vlad <[email protected]>
jeffhammond
force-pushed
the
macosx-os_util-support
branch
from
efd598f to
bcb7398
Compare
|
I just squashed those commits into the main one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight modifications to the original implementation by @alexbatashev.
These are sufficient for a clean build on MacOS and I encourage them to be merged soon. Rebasing Alex's patches is hard given the rate of change in the sycl branch.
Signed-off-by: Hammond, Jeff R [email protected]
Signed-off-by: Alexander Batashev [email protected] (please re-affirm the sign-off that was in your original patch set)