[SYCL] Add MacOS file paths to the lit.cfg file for sycl/test #764
Conversation
|
Looks like you've got some changes from #763 in this PR. |
|
Yeah, that was intentional. I don't think it makes sense to merge this one until that one is in. Should I rebase #763 out? I figured it wouldn't matter if the pull request was implemented as a rebase. |
|
@jeffhammond maybe you should close #763 and rename this PR to something like "[SYCL] Enable RT builds and tests on macOS"? |
The hard-coded paths need some attention from someone who understands the structure of Xcode paths. Presumably, there is a way to capture these in a way that survives filesystem reorganization across OSX versions. Slight modifications to the original implementation by @alexbatashev. Signed-off-by: Hammond, Jeff R <[email protected]> Signed-off-by: Alexander Batashev [email protected] (please re-affirm the sign-off that was in your original patch set)
jeffhammond
force-pushed
the
sycl-test-lit-cgf-macosx
branch
from
9678a42 to
a15b50a
Compare
Signed-off-by: Hammond, Jeff R <[email protected]>
|
I separated this from #763. |
There was a problem hiding this comment.
@jeffhammond is there any urgency in committing this patch? We don't have macOS CI anyway. If you badly need to run tests regularly, you can commit it locally, lit.cfg is not updated very often. In the meantime I'll be working on a proper solution on clang driver side. Personally, I don't feel comfortable committing such an obvious hack.
|
Since it has no impact on anything else, I'd much rather have it merged and generalize it later, rather than have to rebase it into my local repo over and over again. |
|
I think Jeff is likely NOT the only person who will run into this. The change looks pretty harmless. |
bader
changed the title
The hard-coded paths need some attention from someone who understands the structure of Xcode paths. Presumably, there is a way to capture these in a way that survives filesystem reorganization across OSX versions.
Trivial modification to the original implementation by @alexbatashev.
Signed-off-by: Hammond, Jeff R [email protected]
Signed-off-by: Alexander Batashev [email protected] (please re-affirm the sign-off that was in your original patch set)