Skip to content

[SYCL][Level Zero] Fix sub-sub-device in immediate cmdlists mode #7712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2022
Merged

[SYCL][Level Zero] Fix sub-sub-device in immediate cmdlists mode #7712

merged 1 commit into from
Dec 10, 2022

Conversation

aelovikov-intel
Copy link
Contributor

We still need to initialize the command lists similarly to the regular case. Sub-sub-device properties are handler by indexing into those vectors.

@aelovikov-intel
[SYCL][Level Zero] Fix sub-sub-device in immediate cmdlists mode
a09a522 
We still need to initialize the command lists similarly to the regular
case. Sub-sub-device properties are handler by indexing into those
vectors.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner December 8, 2022 21:30
@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Dec 8, 2022 •
edited
Loading

I plan to fix this by adding RUN: lines to the tests being added in intel/llvm-test-suite#1425 and intel/llvm-test-suite#1434. As such, the tests cannot land before #7599 and #7626, although this PR itself can be merged in without any dependencies.

smaslov-intel
smaslov-intel reviewed Dec 9, 2022
View reviewed changes
@aelovikov-intel
Copy link
Contributor Author

@intel/llvm-gatekeepers , this PR is ready.

@againull againull merged commit ed3d35c into intel:sycl Dec 10, 2022
@aelovikov-intel aelovikov-intel deleted the fix-cslice-imm branch April 7, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @smaslov-intel @againull