Skip to content

[SYCL][Doc] Remove now incorrect info from Reduction_status.md #7751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Dec 12, 2022

There might be other things that have been implemented already, but I cannot immediately identify them, if any.

* ext::oneapi::reduction removed in intel#6634
* sycl::item in kernel supported since intel#7478
* sycl::range + many reductions implemented in intel#7456

There might be other things that have been implemented already, but I
cannot immediately identify them, if any.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner December 12, 2022 22:17
@Pennycook
Copy link
Contributor

I couldn't find a way to comment about this line, because you didn't change it:

TODO #4 (Performance): The reductionLoop() has some order in which it choses indexes from the global index space. Currently it has huge stride to help vectorizer and get more vector insturction for the device code, which though may cause competition among devices for the memory due to pretty bad memory locality. On two-socket server CPUs using smaller stride to prioritize better memory locality gives additional perf improvement.

I think you can remove this as well, because it was fixed in #6164.

@aelovikov-intel
Copy link
Contributor Author

@intel/llvm-gatekeepers , this PR is ready.

@bader bader merged commit b51f267 into intel:sycl Dec 13, 2022
@aelovikov-intel aelovikov-intel deleted the red-doc branch December 13, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants