[SYCL] Define collective functors using std #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel::plus should be an alias to std::plus intel::minimum/maximum should use std::less/std::greater Signed-off-by: John Pennycook <[email protected]>
plus<>, minimum<> and maximum<> depend on C++14. Signed-off-by: John Pennycook <[email protected]>
void specializations should be transparent, accepting arbitrary types and using perfect forwarding. Signed-off-by: John Pennycook <[email protected]>
|
LGTM |
romanovvlad
approved these changes
Nov 19, 2019
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
May 18, 2021
) Expose SPIRVToOCL12, SPIRVToOCL20 interfaces in SPIRVToOCL.h This "recommit"s intel#904, which was accidentally "revert"ed by intel#840 Signed-off-by: Yilong Guo <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@6171e51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel::plusshould be an alias tostd::plusintel::minimum/maximumshould usestd::less/std::greaterUsing the
<void>specializations is now only possible using C++14.