[SYCL] Change lowering of 'cl::sycl::select' into SPIR-V #904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
OpSelect
from SPIR-V core spec was used, but comparing tothe SYCL definition of 'select' built-in, it behaves
differently and even takes different arguments.
select
instruction from OpenCL Extended Instruction Set must be usedinstead.
Description of
OpSelect
from SPIR-V core spec:Description of
select
ExtInst:The latter perfectly matches both SYCL and OpenCL specs.
Note: previous implementation emulate ExtInst select behavior over
OpSelect by evaluating MSB of each vector compontent in C++ code, so, it
is functionally correct. However, it uses ext-vectors of booleans, which are
unsupported by OpenCL and confuse underlying OpenCL compilers sometimes
(crashes and hangs experienced in complex applications because of this).